Fix docs.rs builds #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diondokter
approved these changes
Apr 13, 2025
Contributor
|
Thanks for noticing! |
Contributor
|
I made a new release :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kia ora all,
The docs.rs builds have been failing for a while now.
This PR specifies docs.rs builds should be built with the a device feature enabled (as described here), otherwise the build will fail. It's my understanding that the user-facing API is very similar between chips so the docs should still be applicable to the others.
I've also noticed the docs are failing for
nrf-modembut this seems to be a different problem? I'll open a separate issue there.Let me know if this is ok, it's just my best-effort guess at a fix.