Skip to content

Fix datasource update #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fformica merged 1 commit into from
Oct 20, 2025
Merged

Fix datasource update #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
## 2.15.1 (October 20th, 2025)

BUG FIXES:

* Fix data source update incorrectly adding the id into the body

## 2.15.0 (August 28th, 2025)

FEATURES:
Expand Down
2 changes: 1 addition & 1 deletion rest/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (
)

const (
clientVersion = "2.15.0"
clientVersion = "2.15.1"

defaultBase = "https://api.nsone.net"
defaultEndpoint = defaultBase + "/v1/"
Expand Down
2 changes: 2 additions & 0 deletions rest/data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ func (s *DataSourcesService) Create(ds *data.Source) (*http.Response, error) {
// NS1 API docs: https://ns1.com/api/#sources-post
func (s *DataSourcesService) Update(ds *data.Source) (*http.Response, error) {
path := fmt.Sprintf("data/sources/%s", ds.ID)
// must be omitted from the body
ds.ID = ""

req, err := s.client.NewRequest("POST", path, &ds)
if err != nil {
Expand Down
Loading