Skip to content

Validate duplicate registered type #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
spawnia wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Validate duplicate registered type #1963

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8418909
Validate duplicate registered type
spawnia Oct 20, 2021
b250974
Apply fixes from StyleCI
spawnia Oct 20, 2021
435774f
Merge branch 'master' into validate-duplicate-registered-type
spawnia Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions tests/Unit/Schema/Types/LaravelEnumTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace Tests\Unit\Schema\Types;

use GraphQL\Error\InvariantViolation;
use Nuwave\Lighthouse\Schema\TypeRegistry;
use Nuwave\Lighthouse\Schema\Types\LaravelEnumType;
use PHPUnit\Framework\Constraint\Callback;
Expand Down Expand Up @@ -61,4 +62,24 @@ public function testReceivesEnumInstanceInternally(): void
}
');
}

public function testValidatesDuplicateDefinition(): void
{
$this->typeRegistry->register(
new LaravelEnumType(AOrB::class)
);

$this->expectException(InvariantViolation::class);
$schema = $this->buildSchema(/** @lang GraphQL */ '
type Query {
foo: ID
}

enum AOrB {
A
B
}
');
$schema->assertValid();
}
}