Fix issue 39 #185
Open
Fix issue 39 #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… being reset after dismissal of view controller. Fixes issue #39.
Contributor
|
Ideally, it would be great if the transition animator could store and later reset the background color(s) to the correct values. Since the animator objects are fairly generic and are intended to potentially be used with any view controller, making all of the view controllers used with this animator have to know to set their background colors in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue where backgroundColor and tintColor values are not properly being reset after dismissal of view controller. This also adds DerivedData to .gitignore to prevent local env from making its way in to github.
Fixes issue #39.