Update OpenEXR to a newer version for prep of OpenImageIO - #400
Open
nick-l-o3de wants to merge 1 commit into
Open
Update OpenEXR to a newer version for prep of OpenImageIO#400nick-l-o3de wants to merge 1 commit into
nick-l-o3de wants to merge 1 commit into
Conversation
nick-l-o3de
force-pushed
the
update_openexr
branch
2 times, most recently
from
August 15, 2026 16:19
9fddee9 to
3e01d2a
Compare
Updates pull_and_build_from_git to support cleaning properly files that were added. Signed-off-by: Nicholas Lawson <70027408+nick-l-o3de@users.noreply.github.com>
nick-l-o3de
force-pushed
the
update_openexr
branch
from
August 15, 2026 19:38
ae05af4 to
e5a30a1
Compare
nick-l-o3de
commented
Aug 15, 2026
Comment on lines
+638
to
643
| git_clean_command = ['git', 'clean', '-fd'] | ||
| call_result = subprocess.run(subp_args(git_clean_command), | ||
| shell=True, | ||
| capture_output=False, | ||
| cwd=str(self.src_folder.resolve())) | ||
| if call_result.returncode != 0: |
Contributor
Author
There was a problem hiding this comment.
Note, this just adds a clean -fd before the restore command, since restore won't remove untracked files.
nick-l-o3de
commented
Aug 15, 2026
Comment on lines
+133
to
+134
| set(_old_ignore_prefix_path ${CMAKE_IGNORE_PREFIX_PATH}) | ||
| set(CMAKE_IGNORE_PREFIX_PATH ${CMAKE_CURRENT_LIST_DIR}) |
Contributor
Author
There was a problem hiding this comment.
Note, this prevents an infinite recursion problem, where this file would find package and its own folder is added to the package prefix paths.
spham-amzn
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenImageIO requires a newer OpenEXR, and there's been a few security issues in OpenEXR anyway, so its about time to update.
This depends on the IMath hash from #394 - as it sits on "dev" bucket. If we redo that one, we'll have to rev this one too.
This first attempt also produces packages for ios and android, which were not previously generated. If this produces problems, I'll re-disable those, but openEXR is used for image dump and capture in the runtime, like, screenshot stuff, (OPTIONALLY) and it would be nice to get those platforms up to spec for it.