Skip to content

Fixed compiler errors on Xcode 14.3 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aegooby wants to merge 1 commit into
base: release/104.1
Choose a base branch
from
Open

Fixed compiler errors on Xcode 14.3 #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions physx/include/foundation/PxVecQuat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,15 +308,15 @@ PX_FORCE_INLINE bool isValidQuatV(const QuatV q)
const FloatV unitTolerance = FLoad(1e-4f);
const FloatV tmp = FAbs(FSub(QuatLength(q), FOne()));
const BoolV con = FIsGrtr(unitTolerance, tmp);
return isFiniteVec4V(q) & (BAllEqTTTT(con) == 1);
return isFiniteVec4V(q) && (BAllEqTTTT(con) == 1);
}

PX_FORCE_INLINE bool isSaneQuatV(const QuatV q)
{
const FloatV unitTolerance = FLoad(1e-2f);
const FloatV tmp = FAbs(FSub(QuatLength(q), FOne()));
const BoolV con = FIsGrtr(unitTolerance, tmp);
return isFiniteVec4V(q) & (BAllEqTTTT(con) == 1);
return isFiniteVec4V(q) && (BAllEqTTTT(con) == 1);
}

#if PX_LINUX && PX_CLANG
Expand Down
6 changes: 3 additions & 3 deletions physx/include/foundation/PxVecTransform.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ class PxTransformV
PX_FORCE_INLINE bool isValid() const
{
// return p.isFinite() && q.isFinite() && q.isValid();
return isFiniteVec3V(p) & isFiniteQuatV(q) & isValidQuatV(q);
return isFiniteVec3V(p) && isFiniteQuatV(q) && isValidQuatV(q);
}

/**
Expand All @@ -144,7 +144,7 @@ class PxTransformV
PX_FORCE_INLINE bool isSane() const
{
// return isFinite() && q.isSane();
return isFinite() & isSaneQuatV(q);
return isFinite() && isSaneQuatV(q);
}

/**
Expand All @@ -153,7 +153,7 @@ class PxTransformV
PX_FORCE_INLINE bool isFinite() const
{
// return p.isFinite() && q.isFinite();
return isFiniteVec3V(p) & isFiniteQuatV(q);
return isFiniteVec3V(p) && isFiniteQuatV(q);
}

#if PX_LINUX && PX_CLANG
Expand Down