Skip to content

fix history api#266

Open
Ciki wants to merge 1 commit into
o5:masterfrom
Ciki:patch-7
Open

fix history api#266
Ciki wants to merge 1 commit into
o5:masterfrom
Ciki:patch-7

Conversation

@Ciki

@Ciki Ciki commented Feb 29, 2016

Copy link
Copy Markdown
Contributor

handle only own history stack & make history api actually work

handle only own history stack & make history api actually work
@o5

o5 commented Apr 28, 2016

Copy link
Copy Markdown
Owner

Pokud to ma resit neprijemnej problem, nefunkcniho tlacitka BACK, tak mi to neresi :/ To kdysi urcite fungovalo, ale mam pocit, ze se to rozbilo, kdyz nekdo "fixoval" (a ja mergoval) fungovani na pri vice gridu na jedne strane :/

@Ciki

Ciki commented Apr 29, 2016

Copy link
Copy Markdown
Contributor Author

Nie, riesit to ma najma to, aby sa grido nesnazilo handlovat VSETKY zmeny stavov, ale len tie svoje (params.grido=true).
Teda ak si dobre spominam :)

@o5

o5 commented Apr 29, 2016

Copy link
Copy Markdown
Owner

Muzes prosim popsat, jak to zreprodukovat? Diky

Comment thread assets/js/grido.js
var state = $.data(document, this.grido.name + '-query') || '',
query = window.location.search;

if (state !== query) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

staci, ked bude state = '' a query lubovolny string (teda niekde mimo grido niekto nastavi hash), tak grido robi request na refresh. Aspon ak si dobre pamatam, tak toto som riesil

@o5

o5 commented Apr 29, 2016

Copy link
Copy Markdown
Owner

teda niekde mimo grido niekto nastavi hash

To prave nedokazu nasimulovat :/ Pouzivas nette.ajax.js plugin? Ten ajax request ze serveru musi vracet payload.grido, jinak se grido success handler nespusti.

@Ciki

Ciki commented Apr 29, 2016

Copy link
Copy Markdown
Contributor Author

Ano, pouzivam.
success handler sa spusta spravne. Problem je, ze v onPopState uz nekontrolujes ci stav, kt. chces popnut, si ulozil grido alebo nejaka ina komponenta.. cize success handler sa spusti napr. po filtrovani cez grido ale v location.hash si predtym mohla uplne ina komponenta ulozit svoj stav .. a grido ho smz nevie refreshnut.. je to zrozumitelne, co pisem?

@o5 o5 added the CLIENT-SIDE label May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants