Correct mobile vs desktop inconsistency around showing the layer picker button when already in layer picker

[csillag]

Both in desktop and in mobile mode, when using the app, we have a button at the top, for launching the layer picker dialog.

Clicking this button brings up this dialog.

For some reason, in the mobile view, even when this dialog was up, the button (for launching the dialog) was still visible.

I think this serves no useful purpose.

• For opening the dialog, we don't need it since it's open.
• We also don't need it for closing the dialog, because there is a big cancel button for that.
• The only marginally useful thing it still does is indicating where we come from (what was the current layer before opening the selector, but is not strictly required, because it's already marked as "active" in the menu.
• It's presence is not consistent with the desktop mode
• It's presence is counter intuitive, because we don't expect to see the button when we have already pushed it and it has already served it's purpose.

Therefore I propose removing it.

State	Before	After	Comment
Desktop mode, selector closed			App in default view, button is visible
Desktop mode, selector open			Button is now hidden, since we are inside the dialog
Mobile mode, selector closed			App in default view, button is visible
Mobile mode, selector open, network list			Changed.
Mobile mode, selector open, layer list			Changed.
Mobile mode, selector open, layer detaild			Changed.

[github-actions]

Deployed to Cloudflare Pages

Latest commit:	605200323fb42a0d32c436a35a6d959da8d56e95
Status:	✅ Deploy successful!
Preview URL:	https://178cf290.oasis-explorer.pages.dev
Alias:	https://pr-2101.oasis-explorer.pages.dev

[lukaw3d]

I expect this was intentional design for visual balance

[csillag]

Maybe so. I spelled out my rationale in the PR description, and asked @juresobocan for input.

[lubej]

I would rather see, that we keep it.

[donouwens]

I'm not convinced this is an improvement tbh. I agree that we are missing consistency with desktop, but if anything, we should go the other way around - showing the badge on desktop when the menu is active as well.

My argument would be that we should provide the user with clarity on which network they are on at all times. It's part of the usability heuristics of Nielsen and Norman - basically a fundamental requirement in UX.

I do not believe it hurts the user to show what network they are currently on.

[csillag]

I agree that we are missing consistency with desktop, but if anything, we should go the other way around - showing the badge on desktop when the menu is active as well.

OK, let's do that!