Skip to content

Conversation

@ThisIsMissEm
Copy link
Contributor

@ThisIsMissEm ThisIsMissEm commented Sep 29, 2025

This was originally noted in #18 and #19 and changed in #33, however prohibiting just data: and javascript: would not be a sufficient security measure, as there are other URI schemes that are unsafe, such as vbscript: and shortcuts: (apple shortcuts).

Interestingly, I know vbscript: exists, however, it is not registered with IANA: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml

@ThisIsMissEm
Copy link
Contributor Author

cc @matthieusieben

@OllieJC
Copy link

OllieJC commented Nov 8, 2025

I'm still not convince logo_uri shouldn't allow data: schemes - requiring https means more requests and more bandwidth. For a simple SVG it could be as little as a ~230 bytes:

"logo_uri": "data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHdpZHRoPSI4MDAiIGhlaWdodD0iODAwIiB2aWV3Qm94PSIwIDAgMjAgMjAiPjxwYXRoIGQ9Ik03LjggMTBhMi4yIDIuMiAwIDAgMCA0LjQgMCAyLjIgMi4yIDAgMCAwLTQuNCAweiIvPjwvc3ZnPg=="

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants