Skip to content

Conversation

@PieterKas
Copy link
Collaborator

See issue #134

@PieterKas PieterKas requested a review from tulshi as a code owner September 27, 2024 16:03
Copy link
Collaborator

@gffletch gffletch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

* `grant_type` REQUIRED. The value MUST be set to `urn:ietf:params:oauth:grant-type:token-exchange`
* `audience` REQUIRED. The value MUST be set to the Trust Domain name
* `grant_type` REQUIRED. The value MUST be set to `urn:ietf:params:oauth:grant-type:token-exchange`.
* `audience` REQUIRED. The value of the aud claim MUST remain unchanged in a replacement Txn-Token to prevent the Txn-Token from being accepted outside it's current Trust Domain.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in the "Txn-Token Request" section. Do we need to talk about replacement here, or should we have that language in the "Creating Replacement Txn-Tokens" section? We perhaps already have this there. Also, if you delete the "value MUST be set to the Trust Domain name", then we don't have that constraint listed anywhere else. We should make sure we have that specified somewhere if we want to remove it from here.

Copy link
Collaborator Author

@PieterKas PieterKas Oct 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the aud claim is initially defined, it is constrained to the trust domain. Agreed this is in the wrong section. Thanks for catching that. Reading the section on the replacement transaction tokens, it states that the sub and and values must remain unchanged. It may be enough to have the constraint explained in the original definition, so just removing this.,

@tulshi tulshi linked an issue Oct 3, 2024 that may be closed by this pull request
@tulshi tulshi merged commit 3ec3804 into main Oct 4, 2024
2 checks passed
@tulshi tulshi deleted the PieterKas-patch-2 branch October 4, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clarify why the "aud" claim remains unchanged

4 participants