Clarify authentication requriements #239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt at simplifying both client and server authentication requirements throughout the draft.
yaronf
reviewed
Sep 1, 2025
Co-authored-by: Yaron Sheffer <[email protected]>
bc-pi
reviewed
Sep 5, 2025
bc-pi
suggested changes
Sep 5, 2025
Contributor
bc-pi
left a comment
bc-pi
left a comment
There was a problem hiding this comment.
thanks @PieterKas, I think this is moving in the right direction. I've got some suggestions - mostly tooling syntax stuff and a few (hopefully) minor things.
Co-authored-by: Brian Campbell <[email protected]>
Co-authored-by: Brian Campbell <[email protected]>
Co-authored-by: Brian Campbell <[email protected]>
Co-authored-by: Brian Campbell <[email protected]>
Closed
Collaborator
Author
|
Thanks @bc-pi - I appreciate the review - changes accepted. |
tulshi
reviewed
Sep 9, 2025
bc-pi
reviewed
Sep 9, 2025
bc-pi
reviewed
Sep 10, 2025
Co-authored-by: Brian Campbell <[email protected]>
Co-authored-by: Brian Campbell <[email protected]>
tulshi
approved these changes
Oct 29, 2025
bc-pi
approved these changes
Oct 29, 2025
Contributor
bc-pi
left a comment
bc-pi
left a comment
There was a problem hiding this comment.
I've lost track but don't want to have a request for changes hanging over this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at simplifying both client and server authentication requirements throughout the draft (see #198, #198 and #218)