Support sub in userinfo field#45
Open
FerdinandvHagen wants to merge 1 commit intooauth2-proxy:mainfrom
Open
Conversation
The sub field should always be present according to https://connect2id.com/products/server/docs/api/userinfo#claims
|
This looks great - anything I can do to help it get merged? |
3 tasks
sargunv
added a commit
to sargunv/horologia
that referenced
this pull request
Mar 30, 2026
## Summary - Add 8 integration tests for the full OIDC callback flow using `mockoidc` - Fix production bug: normalize token type casing (`tokens.Type()` instead of `tokens.TokenType`) per RFC 6750 - Extend `setupTestServer` with functional options to support OIDC-enabled test environments - Work around mockoidc's missing `sub` claim in userinfo (upstream [PR #45](oauth2-proxy/mockoidc#45)) ## Test plan - [x] All 8 OIDC tests pass: new user, returning user, email auto-link, subject update, email unverified, missing email, redirect preserved, malicious redirect ignored - [x] All existing tests pass (no regressions from `setupTestServer` signature change) - [x] `mise run check` passes (golangci-lint, dprint, gomod-tidy, etc.) Closes SV-38 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Subject (sub) field is not returned on userinfo requests.
According to https://connect2id.com/products/server/docs/api/userinfo#claims this is required.
Added the Subject field and wired it like the other fields.