Add a config option to allow the client to be public#62
Open
thefinn93 wants to merge 1 commit intooauth2-proxy:mainfrom
Open
Add a config option to allow the client to be public#62thefinn93 wants to merge 1 commit intooauth2-proxy:mainfrom
thefinn93 wants to merge 1 commit intooauth2-proxy:mainfrom
Conversation
also allow overriding the provided hostname Signed-off-by: Finn <finn@janky.solutions>
thefinn93
force-pushed
the
public-client-support
branch
from
8ade93c to
303259d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use this with a "public" client (ie. frontend-only) where there is no secret. This should be completely backwards-compatible, only taking effect when the new config options are enabled. Those options are:
PublicClient- if set to true,client_secretis not a required param and is not compared to the configured secret. Presumably the secret would not be configured in this situation.Hostname- if set, used when creating URLs to that reference this server. If left blank, previous behavior is used. I found this was needed to get a browser client to connect. Happy to split this into a separate PR if that's desired.