fix(#991): optimize atom-in-atom XSL with xsl:key - #1166
Open
ImilB wants to merge 2 commits into
Open
Conversation
Closes objectionary#991. ## Problem The `atom-in-atom` XSL transformation exceeds 100ms threshold on large XMIR files (~120ms). ## Root Cause The selector `//o[eo:atom(.) and o[eo:atom(.)]]` calls `eo:atom(.)` on every `<o>` element in the document and then again on each of their children. `eo:atom(.) = exists($o/o[@name=$eo:lambda])` performs a child element lookup each time. The effective cost is O(n × degree), which on large XMIR files with many objects and children exceeds the threshold. ## Solution Added `xsl:key` for fast lookup of atoms and replaced the expensive function calls. Signed-off-by: ImilB <kiwiyt09a@gmail.com>
Signed-off-by: ImilB <kiwiyt09a@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #991.
Problem
The
atom-in-atomXSL transformation exceeds 100ms threshold on large XMIR files (~120ms).Root Cause
The selector
//o[eo:atom(.) and o[eo:atom(.)]]callseo:atom(.)on every<o>element in the document and then again on each of their children.eo:atom(.) = exists($o/o[@name=$eo:lambda])performs a child element lookup each time. The effective cost is O(n × degree), which on large XMIR files with many objects and children exceeds the threshold.Solution
Added
xsl:keyfor fast lookup of atoms and replaced the expensive function calls.