Skip to content

Add abnormally dilated cellular component template#892

Draft
rays22 wants to merge 2 commits into
masterfrom
issue891
Draft

Add abnormally dilated cellular component template#892
rays22 wants to merge 2 commits into
masterfrom
issue891

Conversation

@rays22

@rays22 rays22 commented Oct 13, 2022

Copy link
Copy Markdown
Contributor

This commit intends to add a new phenotype pattern template draft for community review.

If applied, this commit will fix #891.

This commit intends to add a new phenotype pattern template draft for community review.

If applied, this commit will fix #891.
# examples:
# - http://purl.obolibrary.org/obo/MP_0004089 # dilated sarcoplasmic reticulum
# - http://purl.obolibrary.org/obo/MP_0011632 # dilated mitochondrion
# - http://purl.obolibrary.org/obo/HP_0030774 # Mitochondrial swelling

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a transient swelling phenotype or non-transient dilation?
Need conformation from HPO that this example is correct.

@ybradford ybradford Oct 20, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is a ZP example ZP:0012665 http://purl.obolibrary.org/obo/ZP_0012665 Golgi apparatus cholangiocyte dilated, abnormal

http://purl.obolibrary.org/obo/ZP_0101477 endoplasmic reticulum liver dilated, abnormal

ORCiD: 0000-0002-9900-7880


annotations:
- annotationProperty: related_synonym
text: "swollen %s"

@rays22 rays22 Oct 20, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this synonym, because it is misleading.

@pnrobinson

Copy link
Copy Markdown

I do not think it is a good idea to include the time course in the PATO definitions.

@sbello

sbello commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Discussed on the UPheno call 10/20
Need a PATO ticket on the distinction between swollen and dilated
Unclear which is more appropriate to use at the subcellular level
For anatomical entities we probably want both swollen and dilated but the distinction needs to be clear.

@rays22 rays22 marked this pull request as draft October 27, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add abnormally dilated cellular component pattern template

4 participants