[PLAT-119132] only create generated config map when backend is ready #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What changes are proposed in this pull request? 1. Support az aware hashring in Thanos v0.32+ https://thanos.io/tip/components/receive.md/#az-aware-ketama-hashring-experimental, 2. also supported multiple sts in one hashring config 3. fix lint and go dependency issues OSS PR: observatorium#129 ## How is this tested? main_test.go, Make thanos-receive-controller pending test in deployment
No-op when the pods are not ready instead of proceeding tested in integration test cluster
* return when encountering error * waited for all pods ready during generated hashring initialization
jnyi
force-pushed
the
PLAT-119132-hashring
branch
6 times, most recently
from
fe6bbb4 to
1ac9dba
Compare
* support az aware hashring and multiple sts in one hashring (observatorium#129) * support az aware hashring * Update receive-controller.json * support multiple statefulsets in 1 hashring * add more logs * style * fix lint issue * debug * return when encountering error * remove whitespace * Fix k8s permissions (observatorium#133) * Fix k8s permissions * fix ci * fix ci * sync * add pantheon migration state * Revert "Fix k8s permissions (observatorium#133)" This reverts commit e545b83. --------- Co-authored-by: Alec Rajeev <[email protected]> Signed-off-by: Yi Jin <[email protected]>
jnyi
force-pushed
the
PLAT-119132-hashring
branch
from
1ac9dba to
f48bb5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.