Fix Evernote importer bug #443 #449
Conversation
tgrosinger
changed the title
|
|
||
| if (!yarleOptions.useZettelIdAsFilename) { | ||
| noteName += getFilePrefix(note) !== 'Untitled' ? `${separator}${getFilePrefix(note)}` : ''; | ||
| const filePrefix = getFilePrefix(note); |
There was a problem hiding this comment.
Looks like this getFilePrefix can be hoisted out of the if condition since both cases use it now.
| if (filePrefix !== 'Untitled') { | ||
| const combined = `${noteName}${separator}${filePrefix}`; | ||
| // Truncate if combined name is too long | ||
| if (combined.length > MAX_NOTE_NAME_LENGTH) { |
There was a problem hiding this comment.
Maybe just rewrite this so that there is no else case required. Instead, calculate the available space and always add a substr from filePrefix of that length. I think that will allow simplifying this section a bit.
| * @param suffix - Optional suffix to append (e.g., '.resources') | ||
| * @returns A unique name that doesn't conflict with existing items | ||
| */ | ||
| const getUniqueNameForPath = (basePath: string, name: string, suffix: string = ''): string => { |
There was a problem hiding this comment.
I think I remember you adding something similar in the notion api PR? Maybe something like this should be a utility format that can be shared between both.
There was a problem hiding this comment.
Yes, there's also similar tag‑generation logic. However, because I haven't worked with many other importer implementations, these are the only two functions that can be extracted globally, and I'll address this later.
2 participants
Fix two issues: