Implement Eio.Path.native as a Pi backend and add Windows support - #916
Conversation
|
I think this is broken now on Windows due to the changes in |
Should be fixed now (I spotted it too). |
118528e to
224e0af
Compare
|
I've been reading up more on Windows paths and have a commit to slightly simplify the nt path parser, but also split out the tests. Sadly my Windows machine keeps rebooting for reasons unknown so I'll have to push it once I get back to it in person later today I hope :-) |
|
With apologies for the code churn, I've moved to mdx for the windows tests in 1fae694 which is a bit clearer to read than the denser alcotest. I'm trying to get all the portable mdx working again on Windows, but this is just the fs bit. It also drops an alcotest dep on Eio as a result. |
|
my CRLF is messed up, sorry! Can revert 1fae694 (but my Windows machine has just rebooted again!!) |
|
No problem; I squashed them and converted the newlines in Hmm, that doesn't work (failed in CI). I've switched it back to CRLF. |
669cbc8 to
1621ac9
Compare
|
I think we've hit realworldocaml/mdx#294 here.
I tried using |
Incorporates the approach from ocaml-multicore#738. This also makes a behavioural change I noticed while differentially checking Go/Rust/Python. We prefer a \ when serialising Windows paths, even though / is technically allowed. This seems less surprising Co-authored-by: Kento Okura <kentookura@gmail.com>
I partly reverted this, but moved the tests of |
This is split off from @avsm's #908 and rebased on top of #913 and #915.
Incorporates the approach from #738.
I haven't reviewed it yet.