eio_posix: fix build on 32-bit platforms - #917
Merged
Merged
Conversation
avsm
approved these changes
Aug 3, 2026
Collaborator
Author
|
(I'd like to see the CI results from ocaml-ci, but it's stuck and I no longer have admin access to restart it) |
Reported by Stéphane Glondu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @glondu. Fixes #909.
The
MSG_CMSG_CLOEXECdoesn't fit in an OCamlinton some 32-bit platforms, so just use it from C instead of passing it from OCaml. Unclear whether we really want to support eio_posix on 32-bit systems, but the fix is simple.