Add extended 67-constituent tidal set#1
Open
WPringle wants to merge 5 commits into
Open
Conversation
Add the 34 constituents from Tidal_constituents_67.csv that were not yet defined in pytides, and expose the full table as `constituent.extended` (NOAA set left unchanged as the default). - 15 base constituents (MSm; alpha1, sigma1, tau1, beta1, NO1, chi1, phi1, theta1, upsilon1, pi1, psi1; OQ2, H1, H2) with Doodson numbers derived from the table frequencies and group-assigned nodal corrections. - 19 compound constituents (SO1, epsilon2, MKS2, MSN2, eta2, MO3, SO3, SK3, SN4, MK4, SK4, 2MK5, 2SK5, 2MN6, 2MS6, 2MK6, 2SM6, MSK6, 3MK7) defined via member combinations so nodal corrections derive automatically. Greek letters are spelled out in lower case, Latin abbreviations upper case, matching the existing pytides convention. Also: - Add tests validating the extended set against the bundled CSV and a synthetic decompose round-trip; move the CSV into test/data/. - Fix a pre-existing np.float deprecation crash in tide.py that broke decompose() on current NumPy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The numpy pin (>=1.18,<1.19.4) forced pip to build numpy 1.18 from source on Python 3.14 (no wheels available), which failed with "Cannot import 'setuptools.build_meta'". The code runs fine on current numpy (2.4) after the np.float fix, so loosen the numpy constraint and relax the python constraint to a simple lower bound. Also make the test_Tide formzahl assertion tolerant: the exact value drifts with the numpy/scipy/BLAS version because the solver does not fully converge on the short sample record. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Mirror test_Tide_extended for the NOAA constituent set: predict from known constants and confirm decompose() recovers them. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
… the lunisolar K2 tides as in pytides 84f9253 commit
WPringle
changed the title
Author
|
See oceanmodeling/detide#5 for related PR which uses pytides2 and this new extended tidal constituent list capability . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the 34 constituents from Tidal_constituents_67.csv that were not yet defined in pytides, and expose the full table as
constituent.extended(NOAA set left unchanged as the default).Greek letters are spelled out in lower case, Latin abbreviations upper case, matching the existing pytides convention.
Also: