-
-
Notifications
You must be signed in to change notification settings - Fork 848
Implement more Linux syscalls #5705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I have Io uring bindings in a pr that I'm working on, may be best to keep those out of this pr for now, also because I see flags, opcode, etc. being untyped here + I've written against those bindings of mine. |
|
Hey @laytan that sounds very nice! I tried to keep everything simple and since I intended only to write the bare syscalls I did not go further with types and everything else. If you feel like these do not add value I could remove the io_uring related code. |
|
Hey sorry this was left so long, if you want to resolve the conflicts I can merge this. My IO Uring additions have been merged since then. |
|
I will take a look this weekend, thank you for the heads up. |
|
I was going through the changes and had to fix a lot of it up. I pushed them here directly instead of commenting on everything. Do the changes look ok to you / is this ready to go? |
|
Had a look through your changes and those do look good, thank you for taking the time and correcting them. |
While looking for some io_uring specific syscalls around Odin, I ended up extending them with those and some more.
I was able to test most of the syscalls with success, even the io_uring ones, but there still might be something lurking around.
For testing I used a version of Odin with these changes and observed the results with strace.
This was my first go at Odin, please let me know if something feels off in terms of syntax.