fix: linalg.quaternion_from_forward_and_up() #5864
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This is my first PR so sorry for any inconveniences!
For certain argument values, returns incorrect quaternion.
Looked at linalg.quaternion_from_matrix3 (which worked) and discovered a minus sign should have been a pluss sign in linalg.quaternion_from_forward_and_up.
Ran the program below with the current odin compiler and the compiler compiled locally with these changes. Issue was resolved on the locally compiled one!
Here is the test code i used to verify the changes: