[IMP] runbot: use batch date for first seen date #1199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Do
force-pushed
the
18.0-first-seen-batch-date-xdo
branch
from
841a9e4 to
e72d4df
Compare
The log date can be useful to identify a pattern in apparition (alway arround midnight, ...) but it is usually less relevant for apparition when when usually focus on the "commit" so the batch date Moreover the log date can be misleading when the build ran in faketime. Even if it is not always the case, it is possible to have log_dates in the future.
Xavier-Do
force-pushed
the
18.0-first-seen-batch-date-xdo
branch
from
e72d4df to
6c3e359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log date can be useful to identify a pattern in apparition (alway arround midnight, ...) but it is usually less relevant for the first and last apparition when when usually focus on the "commit" so the batch date
Moreover the log date can be misleading when the build ran in faketime. Even if it is not always the case, it is possible to have log_dates in the future.