Skip to content

Conversation

@AliceRoselia
Copy link
Contributor

bench: 2785713

Reapply "Adjustment of the aspiration window after fail high/low."

This reverts commit fc54d87.

But with delta overflow fixed.

The bench is the same as the original pre-revert version, suggesting no functional change except for the delta overflow fix. The code adds a very minimal cost to a negligible path, so no significant slowdown either. With these in mind, this fix should be safe to merge.

bench: 2785713

Reapply "Adjustment of the aspiration window after fail high/low."

This reverts commit fc54d87.

But with delta overflow fixed.
@github-actions
Copy link

clang-format 20 needs to be run on this PR.
If you do not have clang-format installed, the maintainer will run it when merging.
For the exact version please see https://packages.ubuntu.com/plucky/clang-format-20.

(execution 17881268418 / attempt 1)

@vondele
Copy link
Member

vondele commented Sep 21, 2025

I would prefer to leave it to the original author to come up with a new version. However, it is important we understand what is going on.

@AliceRoselia
Copy link
Contributor Author

Could somebody test this version to see if the issues are still present? If not, then I think merging is warranted because the original patch was a gainer.

@Lancali
Copy link

Lancali commented Sep 30, 2025

I can test this version to see if the issues are still present, but as explained in #6296, it is difficult to reproduce.

Likely caused by multithreading, so difficult to reproduce.

If there is a position where the issue can be reproduced with a single thread, I would be happy to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants