BetterGuildTooltip: Fixed startup crash - #195
Open
43eayl5 wants to merge 2 commits into
Open
Conversation
okdevme
requested changes
Aug 14, 2026
okdevme
left a comment
okdevme
left a comment
Owner
There was a problem hiding this comment.
Thanks for the contribution! Please see the comments.
| const Selectors = { | ||
| Guild: Webpack.getByKeys('statusOffline', 'guildDetail') | ||
| get Guild () { | ||
| return Webpack.getByKeys('statusOffline', 'guildDetail') ?? {} |
Owner
There was a problem hiding this comment.
This will cause the module search, which is a very heavy operation, running on every render, multiple times. The module search must be a one-time operation.
Also, the tooltip sometimes randomly disappears instantly after it opens, which is probably caused by this.
| const GuildTooltip = [...Webpack.getWithKey(Filters.byStrings('guild', '__unsupportedReactNodeAsText'), { target: Webpack.getBySource('GuildTooltip', { raw: true })?.declarations })] | ||
| const GuildActions = { | ||
| get preload () { | ||
| return Webpack.getByKeys('preload', 'closePrivateChannel')?.preload |
Owner
There was a problem hiding this comment.
Same thing, the module search must be a one-time operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #187