Refactor token handling, relax field validation, and remove duplicate client_assertion #482
+5
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several minor but important improvements to error handling and data validation in the Okta API client and related models. The main changes include making token retrieval more robust, relaxing validation constraints for the
second_emailfield, and removing an unused parameter in OAuth token generation.API Client Improvements:
ApiClientin bothokta/api_client.pyand the templateopenapi/templates/api_client.mustacheto use.get("token", None)for accessing the token, preventing potentialKeyErrorexceptions if the token is missing from the configuration. [1] [2]Model Validation Adjustments:
second_emailfield in theUserProfilemodel, allowing it to be an empty string instead of requiring at least 5 characters.OAuth Logic Cleanup:
client_assertionparameter from the OAuth access token request, likely as part of cleaning up or correcting the OAuth client credentials flow.Fixes #477 Fixes #473