Skip to content

Fixes #2342 -- get_mimetype tests fail without file in PATH #2343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alzwded wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes #2342 -- get_mimetype tests fail without file in PATH #2343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions tests/utils/test_files.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ end
T["Files utils"]["get_mimetype"] = new_set()
T["Files utils"]["get_mimetype"]["can invoke `file`"] = function()
local orig_system = vim.system
local orig_executable = vim.fn.executable
local _cmd, _opts, _cb = nil, nil, nil
---@diagnostic disable-next-line: duplicate-set-field
vim.system = function(cmds, opts, cb)
Expand All @@ -175,14 +176,24 @@ T["Files utils"]["get_mimetype"]["can invoke `file`"] = function()
}
end

vim.fn.executable = function(s)
if s == "file" then
return 1
else
return orig_executable(s)
end
end

local _type = files.get_mimetype("some_file.txt")
h.eq({ "file", "--mime-type", "some_file.txt" }, _cmd)
h.eq("text/plain", _type)
vim.system = orig_system
vim.fn.executable = orig_executable
end

T["Files utils"]["get_mimetype"]["works without `file`"] = function()
T["Files utils"]["get_mimetype"]["works with fallback"] = function()
local orig_system = vim.system
local orig_executable = vim.fn.executable

local _cmd, _opts, _cb = nil, nil, nil
---@diagnostic disable-next-line: duplicate-set-field
Expand All @@ -197,10 +208,19 @@ T["Files utils"]["get_mimetype"]["works without `file`"] = function()
}
end

vim.fn.executable = function(s)
if s == "file" then
return 0
else
return orig_executable(s)
end
end

local _type = files.get_mimetype("some_file.png")
h.eq({ "file", "--mime-type", "some_file.png" }, _cmd)
h.eq(nil, _cmd)
h.eq("image/png", _type)
vim.system = orig_system
vim.fn.executable = orig_executable
end

return T