Only copy notification images from tmp, runtime, and packaged icons - #10801
Open
Chessing234 wants to merge 4 commits into
Open
Only copy notification images from tmp, runtime, and packaged icons#10801Chessing234 wants to merge 4 commits into
Chessing234 wants to merge 4 commits into
Conversation
A same-uid sender can name file:///home/…/.ssh in a toast. The shell runs as the user and used to copy that path into history.
The JS allowlist is not enough if /tmp/foo is a symlink onto a secret.
…opies. History JSON must not keep a file:// path into /etc or ~/.ssh either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
file://path the sender named, including things like~/.sshand/etc./tmp,/var/tmp,/run/user, and packaged icon dirs, and the copy job re-checks withrealpathso a/tmpsymlink cannot pull in a secret.file://values are dropped from persisted JSON so restore cannot re-open them.Test plan
test/shell.d/notifications-test.sh/tmpChromium avatarfile:///etc/passwddoes not grow a history image fileMade with Cursor