Physical sizes for subresolutions - #4479
Draft
melissalinkert wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3797. Opening as draft for now as this needs work, but I wanted to capture current progress before switching to other tasks.
Following discussion of 9.0.0 with @ome/formats earlier this week, I think I feel better about the idea of calculating physical pixel sizes for subresolutions in the case where resolutions are flattened. We also already have one reader (
DicomReader) that reports a different physical pixel size for each flattened resolution; this is because each resolution's size is stored separately (since one resolution per file).The current state of this pull request adds some minimal API to
FormatToolsso we don't have to re-implement calculation in each reader, and updates appropriate BSD readers to make use of it. Only readers that need to be updated are ones that meet all 3 criteria:CoreMetadata.resolutionCountto something other than 1store.setPixelsPhysicalSize*I expect the following readers would still need to be updated:
This will require configuration updates for any datasets that make use of the updated readers. I also note that we don't have a
.fakeexample that uses both pyramids and physical sizes, so at least one example of that will need to be added to the test repo.