test: compress validator test file with case parity (PR 3/4) - #193
Merged
Merged
Conversation
Adds one _alias_errors_for fixture helper (8 scaffold conversions) and collapses seven AST-verified exact-shape mutate-one-field clusters to table-driven subTest methods. 402 assertion cases before and after (40 removed methods -> 40 table rows); every mutation and expected substring unchanged. Consensus: reviews/ponytail-test-compression-consensus.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HkAvtm89oVSGdUAswG8TRq
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Moves the seven converted alias assertions inside their subTest blocks so failures keep per-case attribution and the loops continue, and renames the two near-identical adjudication table methods to name their nesting level. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HkAvtm89oVSGdUAswG8TRq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch 3 of the approved ponytail-audit remediation, test-only (-201 lines, 402 → 369 methods, case parity 402 → 402 verified by accounting).
_alias_errors_forfixture helper replaces the repeated tempdir/surface-dispatch scaffold (8 conversions; incompatible sites deliberately left alone)subTestmethods (40 methods → 40 rows, every mutation and expected substring unchanged)Gates: full suite green before/after; efficacy oracle unchanged; sibling modules importing this file's helpers green. Consensus:
reviews/ponytail-test-compression-consensus.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01HkAvtm89oVSGdUAswG8TRq