Repository navigation
refactor: merge session classes into repository - #1651
Merged
aanorbel merged 2 commits intoNov 4, 2026
Merged
Conversation
sdsantos
approved these changes
Nov 2, 2026
Comment on lines
+6
to
+8
| data class Error( | ||
| val cause: Throwable? = null, | ||
| ) : SessionState |
Contributor
There was a problem hiding this comment.
I feel this is just the same as LoggedOut, but with a Throwable that is never used. This could be removed and, if necessary, the errorCause could be inside LoggedOut.
|
|
||
| val author = descriptor.author | ||
| val sessionEmail = getStoredSession()?.emailAddress | ||
| val sessionEmail = getSession()?.emailAddress |
Contributor
There was a problem hiding this comment.
I think we should react to the session state flow here, instead of just getting it once no?
| package org.ooni.probe.data.models | ||
|
|
||
| sealed interface SessionState { | ||
| data object Unknown : SessionState |
Comment on lines
+47
to
+50
| suspend fun getSession(): AuthSession? = (sessionState.first() as? SessionState.LoggedIn)?.session | ||
|
|
||
| suspend fun requireSession(): Result<AuthSession, AuthException> = | ||
| getSession()?.let { Success(it) } ?: Failure(AuthException.NotLoggedIn()) |
Contributor
There was a problem hiding this comment.
I feel these methods are unnecessary. We could just use the session state flow everywhere, instead of keeping these small differences. Specially since the Error and Unknown states could be removed.
aanorbel
merged commit Nov 4, 2026
156f8d7
into
issues/1486-update-descriptor
16 of 18 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.