add grpc server metrics. #152
Conversation
Signed-off-by: morvencao <[email protected]>
morvencao
force-pushed
the
br_grpc_metrics
branch
from
d16e703 to
bf060b9
Compare
|
/assign @qiujian16 @skeeey |
|
@morvencao this looks great, I think we also need some description on what value of metrics will reflect the service is degraded. Or as an operator, what metrics should be checked to determine whether the service is not healthy. |
| For example: | ||
| ``` | ||
| grpc_server_started_total{grpc_method="Publish",grpc_service="io.cloudevents.v1.CloudEventService",grpc_type="unary"} 3 | ||
| grpc_server_started_total{grpc_method="Subscribe",grpc_service="io.cloudevents.v1.CloudEventService",grpc_type="server_stream"} 4 |
There was a problem hiding this comment.
for grpc_method="Subscribe",grpc_service="io.cloudevents.v1.CloudEventService", we get them from StreamServerInfo/UnaryServerInfo? so the method or service will not only cloudevents Publish/Subscribe, right?
There was a problem hiding this comment.
right, not only cloudevents Publish/Subscribe, this is just an example.
for other grpc server, eg, cluster-proxy, the service and method will be different.
Signed-off-by: morvencao <[email protected]>
|
added metrics values for healthy/degraded case, along with a rough operator guide. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: morvencao, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 6fecf80
into
open-cluster-management-io:main
3 participants
add gRPC server metrics.