-
Notifications
You must be signed in to change notification settings - Fork 4
New cutout and apply pre-commit #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
martacki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer here if we could do minimal changes compared to upstream only, so that we don't get million merge conflicts in the long run.
style improvements should go there, not to the project repository
| atlite: | ||
| cutout_directory: cutouts | ||
| default_cutout: europe-2023-sarah3-era5 | ||
| default_cutout: europe-jan-2023-sarah3-era5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| default_cutout: europe-jan-2023-sarah3-era5 | |
| default_cutout: europe-jan-2013-sarah3-era5 |
| # base: | ||
| # module: era5 | ||
| europe-2023-sarah3-era5: | ||
| europe-jan-2023-sarah3-era5: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| europe-jan-2023-sarah3-era5: | |
| europe-jan-2013-sarah3-era5: |
rules/emberdata.smk
Outdated
| rule download_ember_data: | ||
| output: | ||
| [str(path) for path in DOWNLOADS.keys()] | ||
| [str(path) for path in DOWNLOADS.keys()], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if those changes are not in upstream, I'd prefer to keep them to avoid unnecessary merge conflicts later.
but you're welcome making this suggestion upstream :)
scripts/add_electricity.py
Outdated
| caps = pd.Series( | ||
| data=ds.indexes["bus"].get_level_values("bus").map(caps), | ||
| index=ds.indexes["bus"] | ||
| index=ds.indexes["bus"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| index=ds.indexes["bus"], | |
| index=ds.indexes["bus"] |
Closes # (if applicable).
Changes proposed in this Pull Request
In this pull request I provide a new cutout for europe.
The cutout was generated starting from the
europe-2013-sarah3-era5.nc, restricting the time span to the month of january. I used this code snippet to do it.The new cutout has the following characteristics.
Checklist
envs/environment.yaml.config/config.default.yaml.doc/configtables/*.csv.doc/data_sources.rst.doc/release_notes.rstis added.