Skip to content

Conversation

@drifter089
Copy link

@drifter089 drifter089 commented Dec 9, 2024

please refer to same PR on my fork to see CI execution

@drifter089
Copy link
Author

drifter089#3

@drifter089 drifter089 self-assigned this Dec 10, 2024
@siddharth-krishna
Copy link
Member

Thanks, Akshat. I'm not sure I'll have time to run it on the machine that generated the benchmarks before today's presentation, so I will test it out afterwards and then review the PR. Some minor suggestions:

  • We don't want to run it in the solver-benchmark CI for now, since the benchmarks are not generated in the CI, so could you comment it out / remove the CI file and instead add a section to the relevant README file on how to run the zenodo update script?
  • The zenodo metadata file doesn't need to be a hidden file, I think?

@drifter089
Copy link
Author

readme updated, file renamed .
CI is now only triggred manually @siddharth-krishna , if you want i can remove the file altogher ,
everything is tested in ZenodoCI anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants