Update ft600 driver translator #53
Conversation
- libonidriver_ft600: uses newer ftdi driver on windows - libonidriver_ft600: Improved register transmission speed - libonidriver_ft600: Patch version bump to 1.0.4 - liboni: Added new error to ONI to inform of bad configuration on controler - liboni: Minor version bump to 4.5.0 - clroni: Minor version bump to 6.3.0
| } | ||
| case ONI_EBADCONTROLLER : | ||
| { | ||
| return "ONI Controller is not compatible"; |
There was a problem hiding this comment.
Not compatible with what? This version of the library?
There was a problem hiding this comment.
This is basically is meant to state "the driver translator can open a low level physical channel to the target hardware but something is not right"
For the ft600, for example, this happens when it can open a connection with a ft600 chip but it is not properly configured.
I thought we could throw this error, for example, if the hardware reported a non-compatible ONI spec. Although we could make a EBADONIVER or something like that for that specific case, it's not like we're gonna run out of error code space soon. But in this specific case, a hardware mismatch on the controller is what I meant. We can change the name of the error and definitely write a better error message.
|
|
||
| #if defined _WIN32 || defined LINUX_ASYNC | ||
| FT_SetStreamPipe(ctx->ftHandle, FALSE, FALSE, pipe_in, ctx->inBlockSize); | ||
| //FT_SetStreamPipe(ctx->ftHandle, FALSE, FALSE, pipe_in, ctx->inBlockSize); |
| return ONI_ESEEKFAILURE; | ||
| } | ||
| Sleep(1); | ||
| //Sleep(1); |
| Sleep(10); | ||
| #if defined _WIN32 || defined LINUX_ASYNC | ||
| FT_ClearStreamPipe(ctx->ftHandle, FALSE, FALSE, pipe_in); | ||
| // FT_ClearStreamPipe(ctx->ftHandle, FALSE, FALSE, pipe_in); |
|
Yah, I mean to remove all the commented stuff, but I prefer to stress-test the changes, specially the transition from the stream stuff. I'll do a clean-up pass after that and squash the commits |
For the ECP5 board, requires firmware v2.0