-
Notifications
You must be signed in to change notification settings - Fork 17
docs: comprehensive documentation updates for OpenAPI patterns and contributor guide #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @kriscoleman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a significant overhaul and expansion of the project's documentation. The primary goal is to provide clearer guidance for developers, both for contributing to the project and for understanding its core architectural patterns, especially concerning remote operations and CLI command usage. These updates aim to improve developer onboarding, maintainability, and the overall clarity of the project's design and functionality. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides a comprehensive set of documentation updates, significantly improving the contributor guide, README, and design documents. A new, detailed document explaining the OpenAPI client pattern has been added, which is a great resource for understanding remote operations. The Makefile has also been improved for a better developer experience.
My review focuses on ensuring the new documentation is accurate and consistent with the project's implementation. I've found a few minor inconsistencies in the new openapi-client-pattern.md file regarding Makefile targets and external links. The suggested changes aim to correct these details to prevent confusion for contributors. Overall, this is an excellent and valuable contribution to the project's documentation.
3b0b139 to
7a61f26
Compare
…uides updates contributing guide to include development setup, available make commands, new generators, testing, remote operations, ci/cd pipeline, and lefthook setup. it also removes the old contributing guide. updates design docs to describe remote flag synchronization and architecture patterns. Signed-off-by: Kris Coleman <[email protected]>
a79ff9f to
ad5bc96
Compare
Summary
Changes
Test Plan
Related Issues
This documentation update follows the implementation of OpenAPI client patterns for remote flag synchronization.