Skip to content

Conversation

@askpt
Copy link
Member

@askpt askpt commented Dec 14, 2025

Signed-off-by: André Silva [email protected]

This PR

This pull request updates the NSwag dependency and build configuration for the OpenFeature.Contrib.Providers.Flipt project. The changes ensure the project uses a newer version of NSwag and the appropriate executable for code generation.

Dependency and build tool updates:

  • Upgraded the NSwag.MSBuild package reference from version 14.3.0 to 14.6.3 in OpenFeature.Contrib.Providers.Flipt.csproj.
  • Updated the build target to use NSwagExe_Net100 instead of NSwagExe_Net90 when generating the REST client code, aligning with the newer NSwag version.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @askpt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a routine maintenance update, specifically upgrading the NSwag.MSBuild package to its latest version. This ensures that the project benefits from the most recent features, bug fixes, and performance improvements provided by NSwag, and aligns the build process with newer .NET runtime versions for OpenAPI client generation.

Highlights

  • NSwag.MSBuild Package Update: The NSwag.MSBuild package has been updated from version 14.3.0 to 14.6.3.
  • NSwag Executable Version: The NSwag build command has been updated to use the NSwagExe_Net100 executable, indicating a shift to a newer .NET target for the NSwag toolchain.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@askpt askpt marked this pull request as ready for review December 14, 2025 15:56
@askpt askpt requested review from a team as code owners December 14, 2025 15:56
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the NSwag.MSBuild package from version 14.3.0 to 14.6.3. While updating dependencies is good practice, this change introduces a breaking issue. The build command for NSwag was modified to use $(NSwagExe_Net100), which is an undefined MSBuild property in the specified package version, and will cause the build to fail. I have provided a critical review comment with a suggested fix to use a valid property, such as $(NSwagExe_Net90) which was used previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants