-
Notifications
You must be signed in to change notification settings - Fork 41
chore: update NSwag.MSBuild package version to 14.6.3 #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: André Silva <[email protected]>
Summary of ChangesHello @askpt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on a routine maintenance update, specifically upgrading the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the NSwag.MSBuild package from version 14.3.0 to 14.6.3. While updating dependencies is good practice, this change introduces a breaking issue. The build command for NSwag was modified to use $(NSwagExe_Net100), which is an undefined MSBuild property in the specified package version, and will cause the build to fail. I have provided a critical review comment with a suggested fix to use a valid property, such as $(NSwagExe_Net90) which was used previously.
Signed-off-by: André Silva [email protected]
This PR
This pull request updates the NSwag dependency and build configuration for the
OpenFeature.Contrib.Providers.Fliptproject. The changes ensure the project uses a newer version of NSwag and the appropriate executable for code generation.Dependency and build tool updates:
NSwag.MSBuildpackage reference from version14.3.0to14.6.3inOpenFeature.Contrib.Providers.Flipt.csproj.NSwagExe_Net100instead ofNSwagExe_Net90when generating the REST client code, aligning with the newer NSwag version.