Skip to content

Align incident status tests with test-case status API#27754

Open
shah-harshit wants to merge 2 commits into1.13from
issue-3837-incident-status-tests-1-13
Open

Align incident status tests with test-case status API#27754
shah-harshit wants to merge 2 commits into1.13from
issue-3837-incident-status-tests-1-13

Conversation

@shah-harshit
Copy link
Copy Markdown
Contributor

Summary

  • update InlineTestCaseIncidentStatus unit tests to use postTestCaseIncidentStatus instead of legacy incident transition/task APIs
  • add/migrate mocks for app store and entity utils required by the current test-case resolution flow
  • adjust assertions for ACK, Assigned, and Resolved transitions to validate testCaseResolutionStatusType and details payloads

Related issue

Closes https://github.com/open-metadata/openmetadata-collate/issues/3837

Test plan

  • yarn test InlineTestCaseIncidentStatus.test.tsx --no-cache
  • Validate CI unit tests on PR

Made with Cursor

… API

Update InlineTestCaseIncidentStatus test expectations and mocks to validate the new test-case resolution status payload flow instead of legacy incident transition/task APIs.

Made-with: Cursor
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 27, 2026

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 63%
63.4% (59543/93912) 43.61% (31545/72332) 46.61% (9477/20329)

@gitar-bot
Copy link
Copy Markdown

gitar-bot Bot commented Apr 27, 2026

Code Review ✅ Approved

Aligns incident status tests with the test-case status API, ensuring consistency in status reporting. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

🔴 Playwright Results — 1 failure(s), 24 flaky

✅ 3675 passed · ❌ 1 failed · 🟡 24 flaky · ⏭️ 84 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 289 0 1 4
🟡 Shard 2 686 0 6 7
🔴 Shard 3 703 1 7 6
🟡 Shard 4 676 0 6 24
✅ Shard 5 673 0 0 35
🟡 Shard 6 648 0 4 8

Genuine Failures (failed on all attempts)

Features/SettingsNavigationPage.spec.ts › should update navigation sidebar (shard 3)
Error: locator.click: Error: strict mode violation: locator('.ant-tree-title:has-text("Explore")').locator('.ant-switch') resolved to 2 elements:
    1) <button type="button" role="switch" aria-checked="true" class="ant-switch ant-switch-checked" data-testid="navigation-switch-/explore">…</button> aka getByTestId('navigation-switch-/explore')
    2) <button type="button" role="switch" aria-checked="true" class="ant-switch ant-switch-checked" data-testid="navigation-switch-/governance/ontology">…</button> aka getByTestId('navigation-switch-/governance/ontology')

Call log:
�[2m  - waiting for locator('.ant-tree-title:has-text("Explore")').locator('.ant-switch')�[22m

🟡 24 flaky test(s) (passed on retry)
  • Pages/UserCreationWithPersona.spec.ts › Create user with persona and verify on profile (shard 1, 1 retry)
  • Features/BulkEditEntity.spec.ts › Glossary (shard 2, 1 retry)
  • Features/DomainFilterQueryFilter.spec.ts › Domain filter should persist across page navigation (shard 2, 1 retry)
  • Features/DomainFilterQueryFilter.spec.ts › Domain filter should work with different asset types (shard 2, 1 retry)
  • Features/DomainTierCertificationVoting.spec.ts › DataProduct - Certification assign, update, and remove (shard 2, 1 retry)
  • Features/Glossary/GlossaryExpandAllWithStatusFilter.spec.ts › Expand All shows all children regardless of status filter (shard 2, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should inherit reviewers from glossary when term is created (shard 2, 1 retry)
  • Features/Permissions/GlossaryPermissions.spec.ts › Team-based permissions work correctly (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 2 retries)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Features/RestoreEntityInheritedFields.spec.ts › Validate restore with Inherited domain and data products assigned (shard 3, 1 retry)
  • Flow/PersonaFlow.spec.ts › Set default persona for team should work properly (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Create custom property and configure search for Dashboard (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Set & Update all CP types on apiCollection (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Add and update Security and SLA tabs (shard 4, 1 retry)
  • Pages/DataContractsSemanticRules.spec.ts › Validate Owner Rule Is_Not (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Rename domain with tags and glossary terms preserves associations (shard 4, 1 retry)
  • Pages/Domains.spec.ts › Multiple consecutive domain renames preserve all associations (shard 4, 1 retry)
  • Pages/Entity.spec.ts › User as Owner Add, Update and Remove (shard 4, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/ODCSImportExport.spec.ts › Multi-object ODCS contract - object selector shows all schema objects (shard 6, 1 retry)
  • Pages/Users.spec.ts › Permissions for table details page for Data Consumer (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant