fix(migration): align PG v200 migration with MySQL#27757
Merged
Conversation
Comment out migrateThreadTasksToTaskEntity in the PostgreSQL v200 migration to match the MySQL fix from PR #27687. The original fix was only applied to MySQL, leaving PostgreSQL deployments exposed to the same Collate CI failure.
github-actions
Bot
added
Ingestion
safe to test
Code Review ✅ ApprovedAligns the PostgreSQL v200 migration schema with existing MySQL configurations. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns PostgreSQL v200 data migration behavior with the existing MySQL v200 workaround by disabling the migrateThreadTasksToTaskEntity step that is currently causing CI failures.
Changes:
- Removed the now-unused static import for
migrateThreadTasksToTaskEntity. - Commented out the
migrateThreadTasksToTaskEntity(handle)invocation in Postgres v200 migration (matching MySQL v200).
Comment on lines
+23
to
+24
| // Causing issues with collate CI, needs to be fixed before enabling this migration | ||
| // @harshach |
There was a problem hiding this comment.
The new inline comment disables a migration step but doesn’t provide a durable tracking reference for when/how to re-enable it. Consider replacing the free-form text and the personal handle mention with a TODO/FIXME that links to the relevant issue/PR (e.g., #27687 or a follow-up ticket), and apply the same wording in both MySQL/Postgres v200 migrations to keep them in sync.
Suggested change
| // Causing issues with collate CI, needs to be fixed before enabling this migration | |
| // @harshach | |
| // TODO: Re-enable after resolving the collation-related migration issue tracked in #27687. |
|
Contributor
🟡 Playwright Results — all passed (20 flaky)✅ 3953 passed · ❌ 0 failed · 🟡 20 flaky · ⏭️ 86 skipped
🟡 20 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
mohityadav766
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrateThreadTasksToTaskEntity(handle)in the PostgreSQL v200 migration to match the MySQL fix from Chore(UI): fix migration issue #27687.openmetadata-service/.../migration/mysql/v200/Migration.java), so PostgreSQL deployments would still hit the same Collate CI failure.After this change,
postgres/v200/Migration.javais byte-for-byte identical tomysql/v200/Migration.javaaside from the package declaration.Test plan
git diffmatches the shape of commit 184eb35 (3 insertions, 2 deletions)diffbetween postgres and mysql Migration.java (excluding package line) reports no differencesmvn spotless:applyleft the file unchanged🤖 Generated with Claude Code