Skip to content

[Fix] Keep using node 16 #3151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+134 −117
Open

[Fix] Keep using node 16 #3151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4796e63
Keep using node 16
HAOCHENYE Jul 18, 2024
df83fe6
update lint
HAOCHENYE Jul 19, 2024
54912ab
tmp commit needs to be ammend
HAOCHENYE Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/merge_stage_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: merge_stage_test

env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
Copy link
Collaborator

@zhouzaida zhouzaida Jul 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use the Node20?

on:
push:
paths-ignore:
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/pr_stage_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: pr_stage_test

env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
on:
pull_request:
paths-ignore:
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config-zh-cn.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ repos:
- id: check-copyright
args: ["mmcv", "tests", "--excludes", "mmcv/ops"]
- repo: https://gitee.com/openmmlab/mirrors-mypy
rev: v0.812
rev: v1.0.0
hooks:
- id: mypy
exclude: |-
Expand Down
3 changes: 2 additions & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,14 +54,15 @@ repos:
- id: check-copyright
args: ["mmcv", "tests", "--excludes", "mmcv/ops"]
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v0.812
rev: v1.0.0
hooks:
- id: mypy
exclude: |-
(?x)(
^test
| ^docs
)
args: ["--disable-error-code=import"]
# - repo: local
# hooks:
# - id: clang-format
Expand Down
Loading