Skip to content

fix: benchmark unit conversions and formatting #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
shomron wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: benchmark unit conversions and formatting #35

shomron wants to merge 2 commits into from

Conversation

@shomron
Copy link
Contributor

@shomron shomron commented Oct 20, 2025 •
edited
Loading

Fix unit conversions and formatting in the CLI bench command.

@shomron
Copy link
Contributor Author

shomron commented Oct 20, 2025

NOTE: Adding tests for this has been tricky because the code lives in a CLI target. I'll followup to see if there's a way to make Swift Package Manager happy with that layout. Otherwise we'd need to consider refactoring.

@shomron shomron requested a review from patrick-east October 20, 2025 20:23
srenatus
srenatus approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good do me -- is there any implication for #41? Should we try to unify them both at some point...? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srenatus srenatus srenatus approved these changes

@patrick-east patrick-east Awaiting requested review from patrick-east

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shomron @srenatus