[CI] upgrade to clang-tidy 20 #3762
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3762 +/- ##
=======================================
Coverage 89.95% 89.95%
=======================================
Files 225 225
Lines 7158 7158
=======================================
Hits 6438 6438
Misses 720 720 🚀 New features to boost your workflow:
|
…. Filter out generated third-party headers
marcalff
reviewed
Nov 24, 2025
| -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ | ||
| -DCMAKE_CXX_CLANG_TIDY="clang-tidy;--quiet;-p;${BUILD_DIR}" | ||
| make -j $(nproc) | ||
| -DCMAKE_CXX_CLANG_TIDY="clang-tidy;--header-filter=.*/opentelemetry-cpp/.*;--exclude-header-filter=.*(internal/absl|third_party|third-party)/.*;--quiet" |
Member
There was a problem hiding this comment.
Is there a way to put this logic (header-filter) in the top level file .clang-tidy instead ?
It is desirable to have all the clang-tidy configuration in the same place, independent of the workflow & makefiles.
marcalff
reviewed
Nov 24, 2025
| -DCMAKE_CXX_FLAGS="-Wno-deprecated-declarations" \ | ||
| -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ | ||
| -DCMAKE_CXX_CLANG_TIDY="clang-tidy;--quiet;-p;build-${{ matrix.cmake_options }}" | ||
| -DCMAKE_CXX_CLANG_TIDY="clang-tidy;--header-filter=.*/opentelemetry-cpp/.*;--exclude-header-filter=.*(internal/absl|third_party|third-party)/.*;--quiet" |
Member
There was a problem hiding this comment.
Is there a way to put this logic (header-filter) in the top level file .clang-tidy instead ?
Member
|
The generated reports (seen in CI) are very nice. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3538
To run clang-tidy on all header files we need to upgrade to version 20.1.0. This version adds the
--exclude-header-filterargument enabling analysis of all project header files excluding theapi/.../internal/abslheaders.Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes