Skip to content

Conversation

@pinoOgni
Copy link
Contributor

This PR just adds the Source named types used in the NameResolverConfig

@pinoOgni pinoOgni requested a review from a team as a code owner December 12, 2025 18:50
Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM!

@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.17%. Comparing base (958f841) to head (b38a765).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1006   +/-   ##
=======================================
  Coverage   47.17%   47.17%           
=======================================
  Files         259      259           
  Lines       26859    26861    +2     
=======================================
+ Hits        12670    12672    +2     
  Misses      13344    13344           
  Partials      845      845           
Flag Coverage Δ
integration-test 23.03% <100.00%> (-0.02%) ⬇️
integration-test-arm 0.00% <0.00%> (ø)
integration-test-vm-${ARCH}-${KERNEL_VERSION} ?
k8s-integration-test 2.70% <0.00%> (-0.01%) ⬇️
oats-test 0.00% <0.00%> (ø)
unittests 48.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Giuseppe Ognibene <[email protected]>
Copy link
Contributor

@mariomac mariomac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@mariomac mariomac merged commit 6b6b0d8 into open-telemetry:main Dec 15, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants