Skip to content

Conversation

@MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 1, 2025

Requirements

  • Reviewer of the codebase for at least 1 month
  • Reviewer for or author of at least 10 substantial contributions to the codebase
  • Nominated by a maintainer: @grcevski

cd @mmat11

@MrAlias MrAlias requested a review from a team as a code owner October 1, 2025 18:38
@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.51%. Comparing base (96272d5) to head (65878b8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #728      +/-   ##
==========================================
+ Coverage   68.23%   68.51%   +0.27%     
==========================================
  Files         200      200              
  Lines       22519    22519              
==========================================
+ Hits        15366    15428      +62     
+ Misses       6095     6034      -61     
+ Partials     1058     1057       -1     
Flag Coverage Δ
integration-test 58.22% <ø> (-0.13%) ⬇️
integration-test-arm 34.51% <ø> (+0.07%) ⬆️
k8s-integration-test 50.32% <ø> (+0.27%) ⬆️
oats-test 39.72% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@skl skl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@rafaelroquetto rafaelroquetto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmat11 these failing integrations test don't cut you any slack - not even here ! :P

Copy link
Contributor

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@grcevski grcevski merged commit 11326a9 into open-telemetry:main Oct 1, 2025
49 of 50 checks passed
@MrAlias MrAlias deleted the mmat-approver branch October 2, 2025 14:50
@MrAlias MrAlias added this to the v0.1.0 milestone Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants