Skip to content

Conversation

@mmat11
Copy link
Contributor

@mmat11 mmat11 commented Oct 10, 2025

Currently when there's a flaky test in a shard, the whole matrix gets canceled. This PR allows continuing the test execution for the other shards

/cc @skl

@mmat11 mmat11 requested a review from a team as a code owner October 10, 2025 13:25
Copy link
Member

@skl skl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, no harm in this - thanks! Though I think only maintainers can actually re-run failed jobs.

@mmat11
Copy link
Contributor Author

mmat11 commented Oct 10, 2025

I think only maintainers can actually re-run failed jobs

I think approvers can do that, I just restarted a job in #755 , I found no way to restart another single shard after restarting a failed one or restart all failed shard tho :/

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.20%. Comparing base (885e4c3) to head (a874af1).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #762      +/-   ##
==========================================
- Coverage   71.28%   71.20%   -0.08%     
==========================================
  Files         238      238              
  Lines       25168    25168              
==========================================
- Hits        17940    17922      -18     
- Misses       6349     6368      +19     
+ Partials      879      878       -1     
Flag Coverage Δ
integration-test 58.02% <ø> (-0.03%) ⬇️
integration-test-arm 33.69% <ø> (-0.58%) ⬇️
k8s-integration-test 49.88% <ø> (-0.01%) ⬇️
oats-test 39.16% <ø> (-0.49%) ⬇️
unittests 46.79% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mariomac mariomac merged commit e3cbcc1 into open-telemetry:main Oct 10, 2025
44 checks passed
@mmat11 mmat11 deleted the matt/dont-fail-fast branch October 29, 2025 17:32
@MrAlias MrAlias added this to the v0.1.0 milestone Oct 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants