add protocol support docs #824
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
- Coverage 55.79% 55.43% -0.37%
==========================================
Files 243 251 +8
Lines 20822 21367 +545
==========================================
+ Hits 11618 11845 +227
- Misses 8427 8717 +290
- Partials 777 805 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MrAlias
left a comment
MrAlias
left a comment
There was a problem hiding this comment.
LGTM outside of the lint errors.
mmat11
left a comment
mmat11
left a comment
There was a problem hiding this comment.
Added some comments, the rest lgtm!
devdocs/features.md
Outdated
| |:--------------|:----------:|------------:|------------------------------------------------------------------------------------|:------:|-------------------:|--------------------------------------------------------------------------------------------------------------------:| | ||
| | HTTP | All | 1.0/1.1/2.0 | All | Yes | Yes | N/A | | ||
| | gRPC | All | 1.0+ | All | Yes | Only in Go | For non go langagues, can't get method for long living connections, will mark method with `*` | | ||
| | MySQL | All | All | All | Yes | No | N/A | |
There was a problem hiding this comment.
Might wanna mention that for already started mysql/postgres connections, we won't be able to have the prepared statements "already prepared" :D
devdocs/features.md
Outdated
| | JsonRPC | Go | All | - | Yes | No | N/A | | ||
| | GraphQL | All but Go | All | All | Yes | No | N/A | | ||
| | Elasticsearch | All but Go | > 7.14 | /_search | Yes | No | N/A | | ||
| | Aws S3 | All but Go | | ? | Yes | No | N/A | |
There was a problem hiding this comment.
| | Aws S3 | All but Go | | ? | Yes | No | N/A | | |
| | AWS S3 | All but Go | | ? | Yes | No | N/A | |
As of now we support basic crud operations such as CreateBucket, DeleteBucket, PutObject, DeleteObject, ListBuckets, ListObjects, GetObject
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Mattia Meleleo <[email protected]>
Co-authored-by: Mattia Meleleo <[email protected]>
Co-authored-by: Mattia Meleleo <[email protected]>
|
@open-telemetry/ebpf-instrumentation-maintainers also added a pull_request_template to remind people to keep the docs up to date, lmk if we want to add more stuff to it |
|
Nice looks good! Let's wait for CI to pass and see if @mmat11 agrees with the changes. |
4 participants
resolves #811