Skip to content

Conversation

@mmat11
Copy link
Contributor

@mmat11 mmat11 commented Oct 30, 2025

Tentative fix for #831

test-suite-python-aws-sqs.log

While investigating this log file, I noticed the last request buffer for sqs.DeleteQueue was being saved as a response buffer. Some code path is setting packetType to 2 (response) even when it's a request buffer. This PR tries avoiding storing the buffer as a response in the path where the buffer is appended

@mmat11 mmat11 requested a review from a team as a code owner October 30, 2025 16:01
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.43%. Comparing base (3e887d4) to head (1744106).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #843   +/-   ##
=======================================
  Coverage   55.42%   55.43%           
=======================================
  Files         251      251           
  Lines       21400    21400           
=======================================
+ Hits        11861    11863    +2     
+ Misses       8731     8730    -1     
+ Partials      808      807    -1     
Flag Coverage Δ
integration-test 23.22% <ø> (-0.05%) ⬇️
integration-test-arm 0.00% <ø> (ø)
integration-test-vm-${ARCH}-${KERNEL_VERSION} 0.00% <ø> (?)
k8s-integration-test 2.78% <ø> (ø)
oats-test 0.00% <ø> (ø)
unittests 46.54% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, let's see if it helps!

Signed-off-by: Mattia Meleleo <[email protected]>
@mmat11 mmat11 force-pushed the matt/fix-flaky-http branch from d5f1105 to 1744106 Compare October 30, 2025 16:21
@grcevski grcevski merged commit 63d55ed into open-telemetry:main Oct 30, 2025
51 checks passed
@MrAlias MrAlias added this to the v0.1.0 milestone Oct 30, 2025
@mmat11 mmat11 deleted the matt/fix-flaky-http branch November 3, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants