Skip to content

Conversation

@grcevski
Copy link
Contributor

This PR adds the span attribute "peer.service" as per the spec for client calls https://opentelemetry.io/docs/specs/semconv/registry/attributes/peer/.

We only set the peer if there's a host name resolved, not using IP addresses.

Fixes #800

@grcevski grcevski requested a review from a team as a code owner October 31, 2025 15:29
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.09%. Comparing base (82fdcc3) to head (14a6b6e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/appolly/app/request/metric_attributes.go 75.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #854      +/-   ##
==========================================
- Coverage   55.37%   55.09%   -0.29%     
==========================================
  Files         251      251              
  Lines       21443    21459      +16     
==========================================
- Hits        11875    11822      -53     
- Misses       8757     8822      +65     
- Partials      811      815       +4     
Flag Coverage Δ
integration-test 23.25% <0.00%> (-0.03%) ⬇️
integration-test-arm 0.00% <0.00%> (ø)
integration-test-vm-${ARCH}-${KERNEL_VERSION} ?
k8s-integration-test 2.76% <0.00%> (-0.01%) ⬇️
oats-test 0.00% <0.00%> (ø)
unittests 46.22% <87.50%> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@mmat11 mmat11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@grcevski grcevski merged commit 31f7983 into open-telemetry:main Oct 31, 2025
54 of 55 checks passed
@MrAlias MrAlias added this to the v0.2.0 milestone Nov 3, 2025
@MrAlias MrAlias mentioned this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Client Spans are missing the now stable attibute peer.service

3 participants