Skip to content

Conversation

@mmat11
Copy link
Contributor

@mmat11 mmat11 commented Nov 3, 2025

  • Fix aws region parsing
  • Add a couple of missing sqs attributes
  • Support additional url styles in s3 requests (bucket.s3.*.amazonaws.com/* / s3.*.amazonaws.com/bucket/*)
  • Increase tests coverage

Signed-off-by: Mattia Meleleo <[email protected]>
@mmat11 mmat11 requested a review from a team as a code owner November 3, 2025 18:08
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 87.03704% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.16%. Comparing base (63defbf) to head (b95c49e).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/appolly/app/request/span_getters.go 0.00% 4 Missing ⚠️
pkg/ebpf/common/http/aws_common.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #863       +/-   ##
===========================================
+ Coverage   25.83%   55.16%   +29.32%     
===========================================
  Files         214      251       +37     
  Lines       19416    21483     +2067     
===========================================
+ Hits         5017    11851     +6834     
+ Misses      13827     8816     -5011     
- Partials      572      816      +244     
Flag Coverage Δ
integration-test 23.24% <0.00%> (-0.03%) ⬇️
integration-test-arm 0.00% <0.00%> (ø)
integration-test-vm-${ARCH}-${KERNEL_VERSION} 0.00% <0.00%> (ø)
k8s-integration-test 2.76% <0.00%> (-0.01%) ⬇️
oats-test 0.00% <0.00%> (ø)
unittests 46.27% <87.03%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@grcevski grcevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Looks great!

@grcevski grcevski merged commit b5891a4 into open-telemetry:main Nov 4, 2025
57 of 58 checks passed
@MrAlias MrAlias added this to the v0.2.0 milestone Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants