-
Notifications
You must be signed in to change notification settings - Fork 707
logutil: convert standard and log attributes #7660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@sahidvelji PTAL |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7660 +/- ##
=====================================
Coverage 78.7% 78.7%
=====================================
Files 186 186
Lines 14689 14705 +16
=====================================
+ Hits 11569 11585 +16
Misses 2780 2780
Partials 340 340
🚀 New features to boost your workflow:
|
sahidvelji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good change, but I think it does not fully address my concern in #7654. I'll comment on the issue.
Part of #7654