Skip to content

Conversation

@pellared
Copy link
Member

@pellared pellared commented Aug 4, 2025

Part of #7654

@pellared
Copy link
Member Author

pellared commented Aug 4, 2025

@sahidvelji PTAL

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.7%. Comparing base (b66629f) to head (48f2474).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7660   +/-   ##
=====================================
  Coverage   78.7%   78.7%           
=====================================
  Files        186     186           
  Lines      14689   14705   +16     
=====================================
+ Hits       11569   11585   +16     
  Misses      2780    2780           
  Partials     340     340           
Files with missing lines Coverage Δ
bridges/otellogr/convert.go 100.0% <100.0%> (ø)
bridges/otellogrus/convert.go 100.0% <100.0%> (ø)
bridges/otelslog/convert.go 100.0% <100.0%> (ø)
bridges/otelzap/convert.go 100.0% <100.0%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sahidvelji sahidvelji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change, but I think it does not fully address my concern in #7654. I'll comment on the issue.

@pellared pellared added enhancement New feature or request bridge: slog Related to the slog bridge bridge: zap Related to the zap bridge bridge: logrus Related to the logrus bridge bridge: logr Related to the logr bridge labels Aug 5, 2025
@pellared

This comment was marked as resolved.

@pellared pellared marked this pull request as ready for review August 7, 2025 11:55
@pellared pellared requested review from a team, MrAlias and dmathieu as code owners August 7, 2025 11:55
@pellared pellared added this to the v1.38.0 milestone Aug 7, 2025
@pellared pellared merged commit b06b2a8 into open-telemetry:main Aug 8, 2025
29 checks passed
@pellared pellared deleted the api-attributes branch August 8, 2025 13:04
@MrAlias MrAlias mentioned this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bridge: logr Related to the logr bridge bridge: logrus Related to the logrus bridge bridge: slog Related to the slog bridge bridge: zap Related to the zap bridge enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants